Skip to content
Snippets Groups Projects
  • Markus Armbruster's avatar
    b15e402f
    trace-events: Fix attribution of trace points to source · b15e402f
    Markus Armbruster authored
    
    Some trace points are attributed to the wrong source file.  Happens
    when we neglect to update trace-events for code motion, or add events
    in the wrong place, or misspell the file name.
    
    Clean up with help of scripts/cleanup-trace-events.pl.  Funnies
    requiring manual post-processing:
    
    * accel/tcg/cputlb.c trace points are in trace-events.
    
    * block.c and blockdev.c trace points are in block/trace-events.
    
    * hw/block/nvme.c uses the preprocessor to hide its trace point use
      from cleanup-trace-events.pl.
    
    * hw/tpm/tpm_spapr.c uses pseudo trace point tpm_spapr_show_buffer to
      guard debug code.
    
    * include/hw/xen/xen_common.h trace points are in hw/xen/trace-events.
    
    * linux-user/trace-events abbreviates a tedious list of filenames to
      */signal.c.
    
    * net/colo-compare and net/filter-rewriter.c use pseudo trace points
      colo_compare_miscompare and colo_filter_rewriter_debug to guard
      debug code.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
    Message-id: 20200806141334.3646302-5-armbru@redhat.com
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    b15e402f
    History
    trace-events: Fix attribution of trace points to source
    Markus Armbruster authored
    
    Some trace points are attributed to the wrong source file.  Happens
    when we neglect to update trace-events for code motion, or add events
    in the wrong place, or misspell the file name.
    
    Clean up with help of scripts/cleanup-trace-events.pl.  Funnies
    requiring manual post-processing:
    
    * accel/tcg/cputlb.c trace points are in trace-events.
    
    * block.c and blockdev.c trace points are in block/trace-events.
    
    * hw/block/nvme.c uses the preprocessor to hide its trace point use
      from cleanup-trace-events.pl.
    
    * hw/tpm/tpm_spapr.c uses pseudo trace point tpm_spapr_show_buffer to
      guard debug code.
    
    * include/hw/xen/xen_common.h trace points are in hw/xen/trace-events.
    
    * linux-user/trace-events abbreviates a tedious list of filenames to
      */signal.c.
    
    * net/colo-compare and net/filter-rewriter.c use pseudo trace points
      colo_compare_miscompare and colo_filter_rewriter_debug to guard
      debug code.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
    Message-id: 20200806141334.3646302-5-armbru@redhat.com
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>