Skip to content
Snippets Groups Projects
  • John Snow's avatar
    111049a4
    blockjob: refactor backup_start as backup_job_create · 111049a4
    John Snow authored
    
    Refactor backup_start as backup_job_create, which only creates the job,
    but does not automatically start it. The old interface, 'backup_start',
    is not kept in favor of limiting the number of nearly-identical interfaces
    that would have to be edited to keep up with QAPI changes in the future.
    
    Callers that wish to synchronously start the backup_block_job can
    instead just call block_job_start immediately after calling
    backup_job_create.
    
    Transactions are updated to use the new interface, calling block_job_start
    only during the .commit phase, which helps prevent race conditions where
    jobs may finish before we even finish building the transaction. This may
    happen, for instance, during empty block backup jobs.
    
    Reported-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Message-id: 1478587839-9834-6-git-send-email-jsnow@redhat.com
    Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
    111049a4
    History
    blockjob: refactor backup_start as backup_job_create
    John Snow authored
    
    Refactor backup_start as backup_job_create, which only creates the job,
    but does not automatically start it. The old interface, 'backup_start',
    is not kept in favor of limiting the number of nearly-identical interfaces
    that would have to be edited to keep up with QAPI changes in the future.
    
    Callers that wish to synchronously start the backup_block_job can
    instead just call block_job_start immediately after calling
    backup_job_create.
    
    Transactions are updated to use the new interface, calling block_job_start
    only during the .commit phase, which helps prevent race conditions where
    jobs may finish before we even finish building the transaction. This may
    happen, for instance, during empty block backup jobs.
    
    Reported-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Message-id: 1478587839-9834-6-git-send-email-jsnow@redhat.com
    Signed-off-by: default avatarJeff Cody <jcody@redhat.com>