Skip to content
Snippets Groups Projects
  • Thomas Huth's avatar
    043c2c1a
    migration: Silence compiler warning in global_state_store_running() · 043c2c1a
    Thomas Huth authored
    
    GCC 9.3.0 on Ubuntu complains:
    
    In file included from /usr/include/string.h:495,
                     from /home/travis/build/huth/qemu/include/qemu/osdep.h:87,
                     from ../migration/global_state.c:13:
    In function ‘strncpy’,
        inlined from ‘global_state_store_running’ at ../migration/global_state.c:47:5:
    /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error:
     ‘__builtin_strncpy’ specified bound 100 equals destination size [-Werror=stringop-truncation]
      106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    ... but we apparently really want to do a strncpy here - the size is already
    checked with the assert() statement right in front of it. To silence the
    warning, simply replace it with our strpadcpy() function.
    
    Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com> (two years ago)
    Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
    Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
    Message-Id: <20200918103430.297167-4-thuth@redhat.com>
    Message-Id: <20200925154027.12672-5-alex.bennee@linaro.org>
    043c2c1a
    History
    migration: Silence compiler warning in global_state_store_running()
    Thomas Huth authored
    
    GCC 9.3.0 on Ubuntu complains:
    
    In file included from /usr/include/string.h:495,
                     from /home/travis/build/huth/qemu/include/qemu/osdep.h:87,
                     from ../migration/global_state.c:13:
    In function ‘strncpy’,
        inlined from ‘global_state_store_running’ at ../migration/global_state.c:47:5:
    /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error:
     ‘__builtin_strncpy’ specified bound 100 equals destination size [-Werror=stringop-truncation]
      106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    ... but we apparently really want to do a strncpy here - the size is already
    checked with the assert() statement right in front of it. To silence the
    warning, simply replace it with our strpadcpy() function.
    
    Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com> (two years ago)
    Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
    Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
    Message-Id: <20200918103430.297167-4-thuth@redhat.com>
    Message-Id: <20200925154027.12672-5-alex.bennee@linaro.org>