Skip to content
Snippets Groups Projects
  • Daniel P. Berrangé's avatar
    51941e46
    ui: enforce TLS when using websockets server · 51941e46
    Daniel P. Berrangé authored
    
    When TLS is required, the primary VNC server considers it to be
    mandatory. ie the server admin decides whether or not TLS is used,
    and the client has to comply with this decision. The websockets
    server, however, treated it as optional, allowing non-TLS clients
    to connect to a server which had setup TLS. Thus enabling websockets
    lowers the security of the VNC server leaving the admin no way to
    enforce use of TLS.
    
    This removes the code that allows non-TLS fallback in the websockets
    server, so that if TLS is requested for VNC it is now mandatory for
    both the primary VNC server and the websockets VNC server.
    
    Signed-off-by: default avatarDaniel P. Berrange <berrange@redhat.com>
    Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
    51941e46
    History
    ui: enforce TLS when using websockets server
    Daniel P. Berrangé authored
    
    When TLS is required, the primary VNC server considers it to be
    mandatory. ie the server admin decides whether or not TLS is used,
    and the client has to comply with this decision. The websockets
    server, however, treated it as optional, allowing non-TLS clients
    to connect to a server which had setup TLS. Thus enabling websockets
    lowers the security of the VNC server leaving the admin no way to
    enforce use of TLS.
    
    This removes the code that allows non-TLS fallback in the websockets
    server, so that if TLS is requested for VNC it is now mandatory for
    both the primary VNC server and the websockets VNC server.
    
    Signed-off-by: default avatarDaniel P. Berrange <berrange@redhat.com>
    Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>