Skip to content
Snippets Groups Projects
  • Akihiko Odaki's avatar
    dfd3bb0a
    cutils: Fix get_relocated_path on Windows · dfd3bb0a
    Akihiko Odaki authored
    
    get_relocated_path() did not have error handling for PathCchSkipRoot()
    because a path given to get_relocated_path() was expected to be a valid
    path containing a drive letter or UNC server/share path elements on
    Windows, but sometimes it turned out otherwise.
    
    The paths passed to get_relocated_path() are defined by macros generated
    by Meson. Meson in turn uses a prefix given by the configure script to
    generate them. For Windows, the script passes /qemu as a prefix to
    Meson by default.
    
    As documented in docs/about/build-platforms.rst, typically MSYS2 is used
    for the build system, but it is also possible to use Linux as well. When
    MSYS2 is used, its Bash variant recognizes /qemu as a MSYS2 path, and
    converts it to a Windows path, adding the MSYS2 prefix including a drive
    letter or UNC server/share path elements. Such a conversion does not
    happen on a shell on Linux however, and /qemu will be passed as is in
    the case.
    
    Implement a proper error handling of PathCchSkipRoot() in
    get_relocated_path() so that it can handle a path without a drive letter
    or UNC server/share path elements.
    
    Reported-by: default avatarStefan Weil <sw@weilnetz.de>
    Signed-off-by: default avatarAkihiko Odaki <akihiko.odaki@daynix.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Message-ID: <20231005064726.6945-1-akihiko.odaki@daynix.com>
    Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    dfd3bb0a
    History
    cutils: Fix get_relocated_path on Windows
    Akihiko Odaki authored
    
    get_relocated_path() did not have error handling for PathCchSkipRoot()
    because a path given to get_relocated_path() was expected to be a valid
    path containing a drive letter or UNC server/share path elements on
    Windows, but sometimes it turned out otherwise.
    
    The paths passed to get_relocated_path() are defined by macros generated
    by Meson. Meson in turn uses a prefix given by the configure script to
    generate them. For Windows, the script passes /qemu as a prefix to
    Meson by default.
    
    As documented in docs/about/build-platforms.rst, typically MSYS2 is used
    for the build system, but it is also possible to use Linux as well. When
    MSYS2 is used, its Bash variant recognizes /qemu as a MSYS2 path, and
    converts it to a Windows path, adding the MSYS2 prefix including a drive
    letter or UNC server/share path elements. Such a conversion does not
    happen on a shell on Linux however, and /qemu will be passed as is in
    the case.
    
    Implement a proper error handling of PathCchSkipRoot() in
    get_relocated_path() so that it can handle a path without a drive letter
    or UNC server/share path elements.
    
    Reported-by: default avatarStefan Weil <sw@weilnetz.de>
    Signed-off-by: default avatarAkihiko Odaki <akihiko.odaki@daynix.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Message-ID: <20231005064726.6945-1-akihiko.odaki@daynix.com>
    Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>