Skip to content
Snippets Groups Projects
  • Stefan Hajnoczi's avatar
    cbc20bfb
    block: move block exports to libblockdev · cbc20bfb
    Stefan Hajnoczi authored
    
    Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd.
    They are not used by other programs and are not otherwise needed in
    libblock.
    
    Undo the recent move of blockdev-nbd.c from blockdev_ss into block_ss.
    Since bdrv_close_all() (libblock) calls blk_exp_close_all()
    (libblockdev) a stub function is required..
    
    Make qemu-nbd.c use signal handling utility functions instead of
    duplicating the code. This helps because os-posix.c is in libblockdev
    and it depends on a qemu_system_killed() symbol that qemu-nbd.c lacks.
    Once we use the signal handling utility functions we also end up
    providing the necessary symbol.
    
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-id: 20200929125516.186715-4-stefanha@redhat.com
    [Fixed s/ndb/nbd/ typo in commit description as suggested by Eric Blake
    --Stefan]
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    cbc20bfb
    History
    block: move block exports to libblockdev
    Stefan Hajnoczi authored
    
    Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd.
    They are not used by other programs and are not otherwise needed in
    libblock.
    
    Undo the recent move of blockdev-nbd.c from blockdev_ss into block_ss.
    Since bdrv_close_all() (libblock) calls blk_exp_close_all()
    (libblockdev) a stub function is required..
    
    Make qemu-nbd.c use signal handling utility functions instead of
    duplicating the code. This helps because os-posix.c is in libblockdev
    and it depends on a qemu_system_killed() symbol that qemu-nbd.c lacks.
    Once we use the signal handling utility functions we also end up
    providing the necessary symbol.
    
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-id: 20200929125516.186715-4-stefanha@redhat.com
    [Fixed s/ndb/nbd/ typo in commit description as suggested by Eric Blake
    --Stefan]
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>