Skip to content
Snippets Groups Projects
  • Markus Armbruster's avatar
    39dc3e4a
    qapi: Convert simple union TpmTypeOptions to flat one · 39dc3e4a
    Markus Armbruster authored
    
    Simple unions predate flat unions.  Having both complicates the QAPI
    schema language and the QAPI generator.  We haven't been using simple
    unions in new code for a long time, because they are less flexible and
    somewhat awkward on the wire.
    
    To prepare for their removal, convert simple union TpmTypeOptions to
    an equivalent flat one, with existing enum TpmType replacing implicit
    enum TpmTypeOptionsKind.  Adds some boilerplate to the schema, which
    is a bit ugly, but a lot easier to maintain than the simple union
    feature.
    
    Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Acked-by: default avatarStefan Berger <stefanb@linux.ibm.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20210917143134.412106-6-armbru@redhat.com>
    [Indentation tidied up]
    39dc3e4a
    History
    qapi: Convert simple union TpmTypeOptions to flat one
    Markus Armbruster authored
    
    Simple unions predate flat unions.  Having both complicates the QAPI
    schema language and the QAPI generator.  We haven't been using simple
    unions in new code for a long time, because they are less flexible and
    somewhat awkward on the wire.
    
    To prepare for their removal, convert simple union TpmTypeOptions to
    an equivalent flat one, with existing enum TpmType replacing implicit
    enum TpmTypeOptionsKind.  Adds some boilerplate to the schema, which
    is a bit ugly, but a lot easier to maintain than the simple union
    feature.
    
    Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Acked-by: default avatarStefan Berger <stefanb@linux.ibm.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20210917143134.412106-6-armbru@redhat.com>
    [Indentation tidied up]