Skip to content
Snippets Groups Projects
  • Pavel Dovgalyuk's avatar
    366a85e4
    replay: fix icount request when replaying clock access · 366a85e4
    Pavel Dovgalyuk authored
    
    Record/replay provides REPLAY_CLOCK_LOCKED macro to access
    the clock when vm_clock_seqlock is locked. This macro is
    needed because replay internals operate icount. In locked case
    replay use icount_get_raw_locked for icount request, which prevents
    excess locking which leads to deadlock. But previously only
    record code used *_locked function and replay did not.
    Therefore sometimes clock access lead to deadlocks.
    This patch fixes clock access for replay too and uses *_locked
    icount access function.
    
    Signed-off-by: default avatarPavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
    Message-Id: <161347990483.1313189.8371838968343494161.stgit@pasha-ThinkPad-X280>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    366a85e4
    History
    replay: fix icount request when replaying clock access
    Pavel Dovgalyuk authored
    
    Record/replay provides REPLAY_CLOCK_LOCKED macro to access
    the clock when vm_clock_seqlock is locked. This macro is
    needed because replay internals operate icount. In locked case
    replay use icount_get_raw_locked for icount request, which prevents
    excess locking which leads to deadlock. But previously only
    record code used *_locked function and replay did not.
    Therefore sometimes clock access lead to deadlocks.
    This patch fixes clock access for replay too and uses *_locked
    icount access function.
    
    Signed-off-by: default avatarPavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
    Message-Id: <161347990483.1313189.8371838968343494161.stgit@pasha-ThinkPad-X280>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
replay-time.c 1.51 KiB