Skip to content
Snippets Groups Projects
  • Markus Armbruster's avatar
    d5938f29
    Clean up inclusion of sysemu/sysemu.h · d5938f29
    Markus Armbruster authored
    
    In my "build everything" tree, changing sysemu/sysemu.h triggers a
    recompile of some 5400 out of 6600 objects (not counting tests and
    objects that don't depend on qemu/osdep.h).
    
    Almost a third of its inclusions are actually superfluous.  Delete
    them.  Downgrade two more to qapi/qapi-types-run-state.h, and move one
    from char/serial.h to char/serial.c.
    
    hw/semihosting/config.c, monitor/monitor.c, qdev-monitor.c, and
    stubs/semihost.c define variables declared in sysemu/sysemu.h without
    including it.  The compiler is cool with that, but include it anyway.
    
    This doesn't reduce actual use much, as it's still included into
    widely included headers.  The next commit will tackle that.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarAlistair Francis <alistair.francis@wdc.com>
    Message-Id: <20190812052359.30071-27-armbru@redhat.com>
    Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
    d5938f29
    History
    Clean up inclusion of sysemu/sysemu.h
    Markus Armbruster authored
    
    In my "build everything" tree, changing sysemu/sysemu.h triggers a
    recompile of some 5400 out of 6600 objects (not counting tests and
    objects that don't depend on qemu/osdep.h).
    
    Almost a third of its inclusions are actually superfluous.  Delete
    them.  Downgrade two more to qapi/qapi-types-run-state.h, and move one
    from char/serial.h to char/serial.c.
    
    hw/semihosting/config.c, monitor/monitor.c, qdev-monitor.c, and
    stubs/semihost.c define variables declared in sysemu/sysemu.h without
    including it.  The compiler is cool with that, but include it anyway.
    
    This doesn't reduce actual use much, as it's still included into
    widely included headers.  The next commit will tackle that.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarAlistair Francis <alistair.francis@wdc.com>
    Message-Id: <20190812052359.30071-27-armbru@redhat.com>
    Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>