Skip to content
Snippets Groups Projects
  • Volker Rümelin's avatar
    53a939f1
    ui/gtk-egl: move function calls back to regular code path · 53a939f1
    Volker Rümelin authored
    
    Commit 6f189a08 ("ui/gtk-egl: Check EGLSurface before doing
    scanout") introduced a regression when QEMU is running with a
    virtio-gpu-gl-device on a host under X11. After the guest has
    initialized the virtio-gpu-gl-device, the guest screen only
    shows "Display output is not active.".
    
    Commit 6f189a08 moved all function calls in
    gd_egl_scanout_texture() to a code path which is only called
    once after gd_egl_init() succeeds in gd_egl_scanout_texture().
    Move all function calls in gd_egl_scanout_texture() back to
    the regular code path so they get always called if one of the
    gd_egl_init() calls was successful.
    
    Fixes: 6f189a08 ("ui/gtk-egl: Check EGLSurface before doing scanout")
    Signed-off-by: default avatarVolker Rümelin <vr_qemu@t-online.de>
    Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20231111104020.26183-1-vr_qemu@t-online.de>
    53a939f1
    History
    ui/gtk-egl: move function calls back to regular code path
    Volker Rümelin authored
    
    Commit 6f189a08 ("ui/gtk-egl: Check EGLSurface before doing
    scanout") introduced a regression when QEMU is running with a
    virtio-gpu-gl-device on a host under X11. After the guest has
    initialized the virtio-gpu-gl-device, the guest screen only
    shows "Display output is not active.".
    
    Commit 6f189a08 moved all function calls in
    gd_egl_scanout_texture() to a code path which is only called
    once after gd_egl_init() succeeds in gd_egl_scanout_texture().
    Move all function calls in gd_egl_scanout_texture() back to
    the regular code path so they get always called if one of the
    gd_egl_init() calls was successful.
    
    Fixes: 6f189a08 ("ui/gtk-egl: Check EGLSurface before doing scanout")
    Signed-off-by: default avatarVolker Rümelin <vr_qemu@t-online.de>
    Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20231111104020.26183-1-vr_qemu@t-online.de>