Skip to content
Snippets Groups Projects
  • Christian Schoenebeck's avatar
    c418f935
    9pfs: disable msize warning for synth driver · c418f935
    Christian Schoenebeck authored
    
    Previous patch introduced a performance warning being logged on host
    side if client connected with an 'msize' <= 8192. Disable this
    performance warning for the synth driver to prevent that warning from
    being printed whenever the 9pfs (qtest) test cases are running.
    
    Introduce a new export flag V9FS_NO_PERF_WARN for that purpose, which
    might also be used to disable such warnings from the CLI in future.
    
    We could have also prevented the warning by simply raising P9_MAX_SIZE
    in virtio-9p-test.c to any value larger than 8192, however in the
    context of test cases it makes sense running for edge cases, which
    includes the lowest 'msize' value supported by the server which is
    4096, hence we want to preserve an msize of 4096 for the test client.
    
    Signed-off-by: default avatarChristian Schoenebeck <qemu_oss@crudebyte.com>
    Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
    Message-Id: <E1kEyDy-0006nN-5A@lizzy.crudebyte.com>
    Signed-off-by: default avatarChristian Schoenebeck <qemu_oss@crudebyte.com>
    c418f935
    History
    9pfs: disable msize warning for synth driver
    Christian Schoenebeck authored
    
    Previous patch introduced a performance warning being logged on host
    side if client connected with an 'msize' <= 8192. Disable this
    performance warning for the synth driver to prevent that warning from
    being printed whenever the 9pfs (qtest) test cases are running.
    
    Introduce a new export flag V9FS_NO_PERF_WARN for that purpose, which
    might also be used to disable such warnings from the CLI in future.
    
    We could have also prevented the warning by simply raising P9_MAX_SIZE
    in virtio-9p-test.c to any value larger than 8192, however in the
    context of test cases it makes sense running for edge cases, which
    includes the lowest 'msize' value supported by the server which is
    4096, hence we want to preserve an msize of 4096 for the test client.
    
    Signed-off-by: default avatarChristian Schoenebeck <qemu_oss@crudebyte.com>
    Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
    Message-Id: <E1kEyDy-0006nN-5A@lizzy.crudebyte.com>
    Signed-off-by: default avatarChristian Schoenebeck <qemu_oss@crudebyte.com>