Skip to content
Snippets Groups Projects
  • Markus Armbruster's avatar
    235e59cf
    qemu-option: Use returned bool to check for failure · 235e59cf
    Markus Armbruster authored
    
    The previous commit enables conversion of
    
        foo(..., &err);
        if (err) {
            ...
        }
    
    to
    
        if (!foo(..., &err)) {
            ...
        }
    
    for QemuOpts functions that now return true / false on success /
    error.  Coccinelle script:
    
        @@
        identifier fun = {
            opts_do_parse, parse_option_bool, parse_option_number,
            parse_option_size, qemu_opt_parse, qemu_opt_rename, qemu_opt_set,
            qemu_opt_set_bool, qemu_opt_set_number, qemu_opts_absorb_qdict,
            qemu_opts_do_parse, qemu_opts_from_qdict_entry, qemu_opts_set,
            qemu_opts_validate
        };
        expression list args, args2;
        typedef Error;
        Error *err;
        @@
        -    fun(args, &err, args2);
        -    if (err)
        +    if (!fun(args, &err, args2))
             {
                 ...
             }
    
    A few line breaks tidied up manually.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20200707160613.848843-15-armbru@redhat.com>
    [Conflict with commit 0b6786a9 "block/amend: refactor qcow2 amend
    options" resolved by rerunning Coccinelle on master's version]
    235e59cf
    History
    qemu-option: Use returned bool to check for failure
    Markus Armbruster authored
    
    The previous commit enables conversion of
    
        foo(..., &err);
        if (err) {
            ...
        }
    
    to
    
        if (!foo(..., &err)) {
            ...
        }
    
    for QemuOpts functions that now return true / false on success /
    error.  Coccinelle script:
    
        @@
        identifier fun = {
            opts_do_parse, parse_option_bool, parse_option_number,
            parse_option_size, qemu_opt_parse, qemu_opt_rename, qemu_opt_set,
            qemu_opt_set_bool, qemu_opt_set_number, qemu_opts_absorb_qdict,
            qemu_opts_do_parse, qemu_opts_from_qdict_entry, qemu_opts_set,
            qemu_opts_validate
        };
        expression list args, args2;
        typedef Error;
        Error *err;
        @@
        -    fun(args, &err, args2);
        -    if (err)
        +    if (!fun(args, &err, args2))
             {
                 ...
             }
    
    A few line breaks tidied up manually.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20200707160613.848843-15-armbru@redhat.com>
    [Conflict with commit 0b6786a9 "block/amend: refactor qcow2 amend
    options" resolved by rerunning Coccinelle on master's version]