Skip to content
Snippets Groups Projects
  • Ani Sinha's avatar
    0ed93f4c
    tests/acpi: update golden master DSDT binary table blobs for q35 · 0ed93f4c
    Ani Sinha authored
    
    In the previously applied commit ("piix4: don't reserve hw resources when
    hotplug is off globally"), we make changes to the ACPI DSDT tables
    such that some ACPI code are not generated when bsel is absent. Since
    as of this point in time, in q35 machines, we do not use bsel for pci
    buses, we need to update the DSDT table blobs.
    This patch updates the DSDT golden master tables for q35 machines.
    At the same time, we clear bios-tables-test-allowed-diff.h for future
    changes which update tables.
    
    Following is a typical diff between the q35 acpi DSDT table blobs:
    
    @@ -1,30 +1,30 @@
     /*
      * Intel ACPI Component Architecture
      * AML/ASL+ Disassembler version 20180105 (64-bit version)
      * Copyright (c) 2000 - 2018 Intel Corporation
      *
      * Disassembling to symbolic ASL+ operators
      *
    - * Disassembly of tests/data/acpi/q35/DSDT, Tue Sep 15 18:52:47 2020
    + * Disassembly of /tmp/aml-3O0DR0, Tue Sep 15 18:52:47 2020
      *
      * Original Table Header:
      *     Signature        "DSDT"
    - *     Length           0x00001DFE (7678)
    + *     Length           0x00001DF6 (7670)
      *     Revision         0x01 **** 32-bit table (V1), no 64-bit math support
    - *     Checksum         0xAC
    + *     Checksum         0x17
      *     OEM ID           "BOCHS "
      *     OEM Table ID     "BXPCDSDT"
      *     OEM Revision     0x00000001 (1)
      *     Compiler ID      "BXPC"
      *     Compiler Version 0x00000001 (1)
      */
     DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
     {
         Scope (\)
         {
             OperationRegion (DBG, SystemIO, 0x0402, One)
             Field (DBG, ByteAcc, NoLock, Preserve)
             {
                 DBGB,   8
             }
    
    @@ -3113,24 +3113,20 @@
                     Name (_ADR, 0x00010000)  // _ADR: Address
                     Method (_S1D, 0, NotSerialized)  // _S1D: S1 Device State
                     {
                         Return (Zero)
                     }
    
                     Method (_S2D, 0, NotSerialized)  // _S2D: S2 Device State
                     {
                         Return (Zero)
                     }
    
                     Method (_S3D, 0, NotSerialized)  // _S3D: S3 Device State
                     {
                         Return (Zero)
                     }
                 }
    -
    -            Method (PCNT, 0, NotSerialized)
    -            {
    -            }
             }
         }
     }
    
    Signed-off-by: default avatarAni Sinha <ani@anisinha.ca>
    Acked-by: default avatarIgor Mammedov <imammedo@redhat.com>
    Message-Id: <20200918084111.15339-12-ani@anisinha.ca>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    0ed93f4c
    History
    tests/acpi: update golden master DSDT binary table blobs for q35
    Ani Sinha authored
    
    In the previously applied commit ("piix4: don't reserve hw resources when
    hotplug is off globally"), we make changes to the ACPI DSDT tables
    such that some ACPI code are not generated when bsel is absent. Since
    as of this point in time, in q35 machines, we do not use bsel for pci
    buses, we need to update the DSDT table blobs.
    This patch updates the DSDT golden master tables for q35 machines.
    At the same time, we clear bios-tables-test-allowed-diff.h for future
    changes which update tables.
    
    Following is a typical diff between the q35 acpi DSDT table blobs:
    
    @@ -1,30 +1,30 @@
     /*
      * Intel ACPI Component Architecture
      * AML/ASL+ Disassembler version 20180105 (64-bit version)
      * Copyright (c) 2000 - 2018 Intel Corporation
      *
      * Disassembling to symbolic ASL+ operators
      *
    - * Disassembly of tests/data/acpi/q35/DSDT, Tue Sep 15 18:52:47 2020
    + * Disassembly of /tmp/aml-3O0DR0, Tue Sep 15 18:52:47 2020
      *
      * Original Table Header:
      *     Signature        "DSDT"
    - *     Length           0x00001DFE (7678)
    + *     Length           0x00001DF6 (7670)
      *     Revision         0x01 **** 32-bit table (V1), no 64-bit math support
    - *     Checksum         0xAC
    + *     Checksum         0x17
      *     OEM ID           "BOCHS "
      *     OEM Table ID     "BXPCDSDT"
      *     OEM Revision     0x00000001 (1)
      *     Compiler ID      "BXPC"
      *     Compiler Version 0x00000001 (1)
      */
     DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
     {
         Scope (\)
         {
             OperationRegion (DBG, SystemIO, 0x0402, One)
             Field (DBG, ByteAcc, NoLock, Preserve)
             {
                 DBGB,   8
             }
    
    @@ -3113,24 +3113,20 @@
                     Name (_ADR, 0x00010000)  // _ADR: Address
                     Method (_S1D, 0, NotSerialized)  // _S1D: S1 Device State
                     {
                         Return (Zero)
                     }
    
                     Method (_S2D, 0, NotSerialized)  // _S2D: S2 Device State
                     {
                         Return (Zero)
                     }
    
                     Method (_S3D, 0, NotSerialized)  // _S3D: S3 Device State
                     {
                         Return (Zero)
                     }
                 }
    -
    -            Method (PCNT, 0, NotSerialized)
    -            {
    -            }
             }
         }
     }
    
    Signed-off-by: default avatarAni Sinha <ani@anisinha.ca>
    Acked-by: default avatarIgor Mammedov <imammedo@redhat.com>
    Message-Id: <20200918084111.15339-12-ani@anisinha.ca>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>