Skip to content
Snippets Groups Projects
  • Hanna Reitz's avatar
    69dca43d
    block: Use bdrv_default_perms() · 69dca43d
    Hanna Reitz authored
    
    bdrv_default_perms() can decide which permission profile to use based on
    the BdrvChildRole, so block drivers do not need to select it explicitly.
    
    The blkverify driver now no longer shares the WRITE permission for the
    image to verify.  We thus have to adjust two places in
    test-block-iothread not to take it.  (Note that in theory, blkverify
    should behave like quorum in this regard and share neither WRITE nor
    RESIZE for both of its children.  In practice, it does not really
    matter, because blkverify is used only for debugging, so we might as
    well keep its permissions rather liberal.)
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20200513110544.176672-30-mreitz@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    69dca43d
    History
    block: Use bdrv_default_perms()
    Hanna Reitz authored
    
    bdrv_default_perms() can decide which permission profile to use based on
    the BdrvChildRole, so block drivers do not need to select it explicitly.
    
    The blkverify driver now no longer shares the WRITE permission for the
    image to verify.  We thus have to adjust two places in
    test-block-iothread not to take it.  (Note that in theory, blkverify
    should behave like quorum in this regard and share neither WRITE nor
    RESIZE for both of its children.  In practice, it does not really
    matter, because blkverify is used only for debugging, so we might as
    well keep its permissions rather liberal.)
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20200513110544.176672-30-mreitz@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>