Skip to content
Snippets Groups Projects
  • Paolo Bonzini's avatar
    cfb5387a
    hmp: remove "change vnc TARGET" command · cfb5387a
    Paolo Bonzini authored
    
    The HMP command \"change vnc TARGET\" is messy:
    
    - it takes an ugly shortcut to determine if the option has an "id",
    with incorrect results if "id=" is not preceded by an unescaped
    comma.
    
    - it deletes the existing QemuOpts and does not try to rollback
    if the parsing fails (which is not causing problems, but only due to
    how VNC options are parsed)
    
    - because it uses the same parsing function as "-vnc", it forces
    the latter to not support "-vnc help".
    
    On top of this, it uses a deprecated QMP command, thus getting in
    the way of removing the QMP command.  Since the usecase for the
    command is not clear, just remove it and send "change vnc password"
    directly to the QMP "change-vnc-password" command.
    
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarGerd Hoffmann <kraxel@redhat.com>
    Message-Id: <20210120144235.345983-2-pbonzini@redhat.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    cfb5387a
    History
    hmp: remove "change vnc TARGET" command
    Paolo Bonzini authored
    
    The HMP command \"change vnc TARGET\" is messy:
    
    - it takes an ugly shortcut to determine if the option has an "id",
    with incorrect results if "id=" is not preceded by an unescaped
    comma.
    
    - it deletes the existing QemuOpts and does not try to rollback
    if the parsing fails (which is not causing problems, but only due to
    how VNC options are parsed)
    
    - because it uses the same parsing function as "-vnc", it forces
    the latter to not support "-vnc help".
    
    On top of this, it uses a deprecated QMP command, thus getting in
    the way of removing the QMP command.  Since the usecase for the
    command is not clear, just remove it and send "change vnc password"
    directly to the QMP "change-vnc-password" command.
    
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarGerd Hoffmann <kraxel@redhat.com>
    Message-Id: <20210120144235.345983-2-pbonzini@redhat.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>