Skip to content
Snippets Groups Projects
  • Eric Blake's avatar
    ac132d05
    nbd: Replace bool structured_reply with mode enum · ac132d05
    Eric Blake authored
    
    The upcoming patches for 64-bit extensions requires various points in
    the protocol to make decisions based on what was negotiated.  While we
    could easily add a 'bool extended_headers' alongside the existing
    'bool structured_reply', this does not scale well if more modes are
    added in the future.  Better is to expose the mode enum added in the
    recent commit bfe04d0a out to a wider use in the code base.
    
    Where the code previously checked for structured_reply being set or
    clear, it now prefers checking for an inequality; this works because
    the nodes are in a continuum of increasing abilities, and allows us to
    touch fewer places if we ever insert other modes in the middle of the
    enum.  There should be no semantic change in this patch.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-ID: <20230829175826.377251-20-eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
    ac132d05
    History
    nbd: Replace bool structured_reply with mode enum
    Eric Blake authored
    
    The upcoming patches for 64-bit extensions requires various points in
    the protocol to make decisions based on what was negotiated.  While we
    could easily add a 'bool extended_headers' alongside the existing
    'bool structured_reply', this does not scale well if more modes are
    added in the future.  Better is to expose the mode enum added in the
    recent commit bfe04d0a out to a wider use in the code base.
    
    Where the code previously checked for structured_reply being set or
    clear, it now prefers checking for an inequality; this works because
    the nodes are in a continuum of increasing abilities, and allows us to
    touch fewer places if we ever insert other modes in the middle of the
    enum.  There should be no semantic change in this patch.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-ID: <20230829175826.377251-20-eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>