Skip to content
Snippets Groups Projects
  • Paolo Bonzini's avatar
    09e93326
    build: replace ninjatool with ninja · 09e93326
    Paolo Bonzini authored
    
    Now that the build is done entirely by Meson, there is no need
    to keep the Makefile conversion.  Instead, we can ask Ninja about
    the targets it exposes and forward them.
    
    The main advantages are, from smallest to largest:
    
    - reducing the possible namespace pollution within the Makefile
    
    - removal of a relatively large Python program
    
    - faster build because parsing Makefile.ninja is slower than
    parsing build.ninja; and faster build after Meson runs because
    we do not have to generate Makefile.ninja.
    
    - tracking of command lines, which provides more accurate rebuilds
    
    In addition the change removes the requirement for GNU make 3.82, which
    was annoying on Mac, and avoids bugs on Windows due to ninjatool not
    knowing how to convert Windows escapes to POSIX escapes.
    
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    09e93326
    History
    build: replace ninjatool with ninja
    Paolo Bonzini authored
    
    Now that the build is done entirely by Meson, there is no need
    to keep the Makefile conversion.  Instead, we can ask Ninja about
    the targets it exposes and forward them.
    
    The main advantages are, from smallest to largest:
    
    - reducing the possible namespace pollution within the Makefile
    
    - removal of a relatively large Python program
    
    - faster build because parsing Makefile.ninja is slower than
    parsing build.ninja; and faster build after Meson runs because
    we do not have to generate Makefile.ninja.
    
    - tracking of command lines, which provides more accurate rebuilds
    
    In addition the change removes the requirement for GNU make 3.82, which
    was annoying on Mac, and avoids bugs on Windows due to ninjatool not
    knowing how to convert Windows escapes to POSIX escapes.
    
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>