Skip to content
Snippets Groups Projects
Commit ae8268e2 authored by Filippo Cremonese's avatar Filippo Cremonese
Browse files

More descriptive exception text on command failure

parent 3f93f954
No related branches found
No related tags found
No related merge requests found
...@@ -19,7 +19,7 @@ class CloneAction(Action): ...@@ -19,7 +19,7 @@ class CloneAction(Action):
logging.error(f"Script executed: {self.script_to_run}") logging.error(f"Script executed: {self.script_to_run}")
logging.error(f"STDOUT: {result.stdout}") logging.error(f"STDOUT: {result.stdout}")
logging.error(f"STDERR: {result.stderr}") logging.error(f"STDERR: {result.stderr}")
raise Exception("Script failed") raise Exception("Clone script failed")
def is_satisfied(self): def is_satisfied(self):
source_dir = per_action_env(self)["SOURCE_DIR"] source_dir = per_action_env(self)["SOURCE_DIR"]
......
...@@ -17,7 +17,7 @@ class ConfigureAction(Action): ...@@ -17,7 +17,7 @@ class ConfigureAction(Action):
logging.error(f"Script executed: {self.script_to_run}") logging.error(f"Script executed: {self.script_to_run}")
logging.error(f"STDOUT: {result.stdout}") logging.error(f"STDOUT: {result.stdout}")
logging.error(f"STDERR: {result.stderr}") logging.error(f"STDERR: {result.stderr}")
raise Exception("Script failed") raise Exception("Configure script failed")
def is_satisfied(self): def is_satisfied(self):
return os.path.exists(self._build_dir()) return os.path.exists(self._build_dir())
......
...@@ -24,7 +24,7 @@ class InstallAction(Action): ...@@ -24,7 +24,7 @@ class InstallAction(Action):
logging.error(f"Script executed: {self.script_to_run}") logging.error(f"Script executed: {self.script_to_run}")
logging.error(f"STDOUT: {result.stdout}") logging.error(f"STDOUT: {result.stdout}")
logging.error(f"STDERR: {result.stderr}") logging.error(f"STDERR: {result.stderr}")
raise Exception("Script failed") raise Exception("Install script failed")
post_file_list = self._index_directory(genv["TMP_ROOT"], strip_prefix=f"{genv['TMP_ROOT']}{genv['ORCHESTRA_ROOT']}") post_file_list = self._index_directory(genv["TMP_ROOT"], strip_prefix=f"{genv['TMP_ROOT']}{genv['ORCHESTRA_ROOT']}")
new_files = [f for f in post_file_list if f not in pre_file_list] new_files = [f for f in post_file_list if f not in pre_file_list]
...@@ -69,7 +69,7 @@ class InstallAction(Action): ...@@ -69,7 +69,7 @@ class InstallAction(Action):
logging.error(f"Script executed: {copy_command}") logging.error(f"Script executed: {copy_command}")
logging.error(f"STDOUT: {result.stdout}") logging.error(f"STDOUT: {result.stdout}")
logging.error(f"STDERR: {result.stderr}") logging.error(f"STDERR: {result.stderr}")
raise Exception("Script failed") raise Exception("Post-install script failed (might be a bug in Orchestra)")
os.makedirs(install_component_dir(self.index.config), exist_ok=True) os.makedirs(install_component_dir(self.index.config), exist_ok=True)
installed_component_path = install_component_path(self.build.component.name, self.index.config) installed_component_path = install_component_path(self.build.component.name, self.index.config)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment