Skip to content
  • Markus Armbruster's avatar
    fec33318
    keyval: Fix and clarify grammar · fec33318
    Markus Armbruster authored
    
    
    The grammar has a few issues:
    
    * key-fragment = / [^=,.]* /
    
      Prose restricts key fragments: they "must be valid QAPI names or
      consist only of decimal digits".  Technically, '' consists only of
      decimal digits.  The code rejects that.  Fix the grammar.
    
    * val          = { / [^,]* / | ',,' }
    
      Use + instead of *.  Accepts the same language.
    
    * val-no-key   = / [^=,]* /
    
      The code rejects an empty value.  Fix the grammar.
    
    * Section "Additional syntax for use with an implied key" is
      confusing.  Rewrite it.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <20201011073505.1185335-2-armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    fec33318
    keyval: Fix and clarify grammar
    Markus Armbruster authored
    
    
    The grammar has a few issues:
    
    * key-fragment = / [^=,.]* /
    
      Prose restricts key fragments: they "must be valid QAPI names or
      consist only of decimal digits".  Technically, '' consists only of
      decimal digits.  The code rejects that.  Fix the grammar.
    
    * val          = { / [^,]* / | ',,' }
    
      Use + instead of *.  Accepts the same language.
    
    * val-no-key   = / [^=,]* /
    
      The code rejects an empty value.  Fix the grammar.
    
    * Section "Additional syntax for use with an implied key" is
      confusing.  Rewrite it.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <20201011073505.1185335-2-armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading