Skip to content
  • Marc-André Lureau's avatar
    f9509d15
    block: Use qemu_enum_parse() in blkdebug_debug_breakpoint() · f9509d15
    Marc-André Lureau authored
    
    
    The error message on invalid blkdebug events changes from
    
        qemu-system-x86_64: LOCATION: Invalid event name "VALUE"
    
    to
    
        qemu-system-x86_64: LOCATION: invalid parameter value: VALUE
    
    Slight degradation, but the message is sub-par even before the patch.
    When complaining about a parameter value, both parameter name and
    value should be mentioned, as the value may well not be unique.  Left
    for another day.
    
    Also left is the error message's unhelpful location: it points to the
    config=FILENAME rather than into that file.
    
    Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20170822132255.23945-11-marcandre.lureau@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    [Rebased, commit message rewritten]
    Cc: Kevin Wolf <kwolf@redhat.com>
    Cc: Max Reitz <mreitz@redhat.com>
    Cc: qemu-block@nongnu.org
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <1503564371-26090-8-git-send-email-armbru@redhat.com>
    f9509d15
    block: Use qemu_enum_parse() in blkdebug_debug_breakpoint()
    Marc-André Lureau authored
    
    
    The error message on invalid blkdebug events changes from
    
        qemu-system-x86_64: LOCATION: Invalid event name "VALUE"
    
    to
    
        qemu-system-x86_64: LOCATION: invalid parameter value: VALUE
    
    Slight degradation, but the message is sub-par even before the patch.
    When complaining about a parameter value, both parameter name and
    value should be mentioned, as the value may well not be unique.  Left
    for another day.
    
    Also left is the error message's unhelpful location: it points to the
    config=FILENAME rather than into that file.
    
    Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20170822132255.23945-11-marcandre.lureau@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    [Rebased, commit message rewritten]
    Cc: Kevin Wolf <kwolf@redhat.com>
    Cc: Max Reitz <mreitz@redhat.com>
    Cc: qemu-block@nongnu.org
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <1503564371-26090-8-git-send-email-armbru@redhat.com>
Loading