-
Eric Blake authored
Commit 9a6d1acb assumed that 'qom-type' could be removed from QemuOpts with no ill effects. However, this command line proves otherwise: $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio \ -object rng-random,filename=/dev/urandom,id=rng0 \ -device virtio-rng-pci,rng=rng0 qemu-system-x86_64: -object rng-random,filename=/dev/urandom,id=rng0: Parameter 'qom-type' is missing Fix the regression by restoring qom-type in opts after its temporary removal that was needed for the duration of user_creatable_add_opts(). Reported-by:
Richard W. M. Jones <rjones@redhat.com>
Signed-off-by:
Eric Blake <eblake@redhat.com>
Reviewed-by:
Markus Armbruster <armbru@redhat.com>
Tested-by:
Richard W.M. Jones <rjones@redhat.com>
Message-id: 20170323160315.19696-1-eblake@redhat.com
Signed-off-by:
Peter Maydell <peter.maydell@linaro.org>Eric Blake authoredCommit 9a6d1acb assumed that 'qom-type' could be removed from QemuOpts with no ill effects. However, this command line proves otherwise: $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio \ -object rng-random,filename=/dev/urandom,id=rng0 \ -device virtio-rng-pci,rng=rng0 qemu-system-x86_64: -object rng-random,filename=/dev/urandom,id=rng0: Parameter 'qom-type' is missing Fix the regression by restoring qom-type in opts after its temporary removal that was needed for the duration of user_creatable_add_opts(). Reported-by:
Richard W. M. Jones <rjones@redhat.com>
Signed-off-by:
Eric Blake <eblake@redhat.com>
Reviewed-by:
Markus Armbruster <armbru@redhat.com>
Tested-by:
Richard W.M. Jones <rjones@redhat.com>
Message-id: 20170323160315.19696-1-eblake@redhat.com
Signed-off-by:
Peter Maydell <peter.maydell@linaro.org>
Loading