Skip to content
  • Eric Blake's avatar
    3c1fa35d
    qemu-nbd: Fail earlier for -c/-d on non-linux · 3c1fa35d
    Eric Blake authored
    
    
    Connecting to a /dev/nbdN device is a Linux-specific action.
    We were already masking -c and -d from 'qemu-nbd --help' on
    non-linux.  However, while -d fails with a sensible error
    message, it took hunting through a couple of files to prove
    that.  What's more, the code for -c doesn't fail until after
    it has created a pthread and tried to open a device - possibly
    even printing an error message with %m on a non-Linux platform
    in spite of the comment that %m is glibc-specific.  Make the
    failure happen sooner, then get rid of stubs that are no
    longer needed because of the early exits.
    
    While at it: tweak the blank newlines in --help output to be
    consistent, whether or not built on Linux.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20181215135324.152629-7-eblake@redhat.com>
    Reviewed-by: default avatarRichard W.M. Jones <rjones@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    3c1fa35d
    qemu-nbd: Fail earlier for -c/-d on non-linux
    Eric Blake authored
    
    
    Connecting to a /dev/nbdN device is a Linux-specific action.
    We were already masking -c and -d from 'qemu-nbd --help' on
    non-linux.  However, while -d fails with a sensible error
    message, it took hunting through a couple of files to prove
    that.  What's more, the code for -c doesn't fail until after
    it has created a pthread and tried to open a device - possibly
    even printing an error message with %m on a non-Linux platform
    in spite of the comment that %m is glibc-specific.  Make the
    failure happen sooner, then get rid of stubs that are no
    longer needed because of the early exits.
    
    While at it: tweak the blank newlines in --help output to be
    consistent, whether or not built on Linux.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20181215135324.152629-7-eblake@redhat.com>
    Reviewed-by: default avatarRichard W.M. Jones <rjones@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Loading