Skip to content
  • John Snow's avatar
    f67432a2
    jobs: change start callback to run callback · f67432a2
    John Snow authored
    
    
    Presently we codify the entry point for a job as the "start" callback,
    but a more apt name would be "run" to clarify the idea that when this
    function returns we consider the job to have "finished," except for
    any cleanup which occurs in separate callbacks later.
    
    As part of this clarification, change the signature to include an error
    object and a return code. The error ptr is not yet used, and the return
    code while captured, will be overwritten by actions in the job_completed
    function.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 20180830015734.19765-2-jsnow@redhat.com
    Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    f67432a2
    jobs: change start callback to run callback
    John Snow authored
    
    
    Presently we codify the entry point for a job as the "start" callback,
    but a more apt name would be "run" to clarify the idea that when this
    function returns we consider the job to have "finished," except for
    any cleanup which occurs in separate callbacks later.
    
    As part of this clarification, change the signature to include an error
    object and a return code. The error ptr is not yet used, and the return
    code while captured, will be overwritten by actions in the job_completed
    function.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 20180830015734.19765-2-jsnow@redhat.com
    Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Loading