Skip to content
  • Yang Hongyang's avatar
    f018d8cd
    QEMUSizedBuffer: only free qsb that qemu_bufopen allocated · f018d8cd
    Yang Hongyang authored
    
    
    Only free qsb that qemu_bufopen allocated, and also allow
    qemu_bufopen accept qsb as input for write operation. It
    will make the API more logical:
    1.If you create the QEMUSizedBuffer yourself, you need to
      free it by using qsb_free() but not depends on other API
      like qemu_fclose.
    2.allow qemu_bufopen() accept QEMUSizedBuffer as input for
      write operation, otherwise, it will be a little strange
      for this API won't accept the second parameter.
    
    This brings API change, since there are only 3
    users of this API currently, this change only impact the
    first one which will be fixed in patch 2 of this patchset,
    so I think it is safe to do this change.
    
    1     70  tests/test-vmstate.c <<open_mem_file_read>>
                return qemu_bufopen("r", qsb);
    2    404  tests/test-vmstate.c <<test_save_noskip>>
                QEMUFile *fsave = qemu_bufopen("w", NULL);
    3    424  tests/test-vmstate.c <<test_save_skip>>
                QEMUFile *fsave = qemu_bufopen("w", NULL);
    
    Signed-off-by: default avatarYang Hongyang <yanghy@cn.fujitsu.com>
    Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
    Cc: Juan Quintela <quintela@redhat.com>
    Cc: Amit Shah <amit.shah@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
    f018d8cd
    QEMUSizedBuffer: only free qsb that qemu_bufopen allocated
    Yang Hongyang authored
    
    
    Only free qsb that qemu_bufopen allocated, and also allow
    qemu_bufopen accept qsb as input for write operation. It
    will make the API more logical:
    1.If you create the QEMUSizedBuffer yourself, you need to
      free it by using qsb_free() but not depends on other API
      like qemu_fclose.
    2.allow qemu_bufopen() accept QEMUSizedBuffer as input for
      write operation, otherwise, it will be a little strange
      for this API won't accept the second parameter.
    
    This brings API change, since there are only 3
    users of this API currently, this change only impact the
    first one which will be fixed in patch 2 of this patchset,
    so I think it is safe to do this change.
    
    1     70  tests/test-vmstate.c <<open_mem_file_read>>
                return qemu_bufopen("r", qsb);
    2    404  tests/test-vmstate.c <<test_save_noskip>>
                QEMUFile *fsave = qemu_bufopen("w", NULL);
    3    424  tests/test-vmstate.c <<test_save_skip>>
                QEMUFile *fsave = qemu_bufopen("w", NULL);
    
    Signed-off-by: default avatarYang Hongyang <yanghy@cn.fujitsu.com>
    Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
    Cc: Juan Quintela <quintela@redhat.com>
    Cc: Amit Shah <amit.shah@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
Loading