Skip to content
  • Philippe Mathieu-Daudé's avatar
    ec3ad0fa
    tests/npcm7xx_adc: Clean up global variable shadowing · ec3ad0fa
    Philippe Mathieu-Daudé authored
    
    
    Rename the global 'adc' variable in order to avoid:
    
      tests/qtest/npcm7xx_adc-test.c:98:58: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static uint32_t adc_read_con(QTestState *qts, const ADC *adc)
                                                               ^
      tests/qtest/npcm7xx_adc-test.c:103:55: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_write_con(QTestState *qts, const ADC *adc, uint32_t value)
                                                            ^
      tests/qtest/npcm7xx_adc-test.c:108:59: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static uint32_t adc_read_data(QTestState *qts, const ADC *adc)
                                                                ^
      tests/qtest/npcm7xx_adc-test.c:119:53: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_qom_set(QTestState *qts, const ADC *adc,
                                                          ^
      tests/qtest/npcm7xx_adc-test.c:135:57: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_write_input(QTestState *qts, const ADC *adc,
                                                              ^
      tests/qtest/npcm7xx_adc-test.c:144:56: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_write_vref(QTestState *qts, const ADC *adc, uint32_t value)
                                                             ^
      tests/qtest/npcm7xx_adc-test.c:162:59: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static uint32_t adc_prescaler(QTestState *qts, const ADC *adc)
                                                                ^
      tests/qtest/npcm7xx_adc-test.c:175:64: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_wait_conv_finished(QTestState *qts, const ADC *adc,
                                                                     ^
      tests/qtest/npcm7xx_adc-test.c:196:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:207:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:235:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:267:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:293:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:311:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:93:5: note: previous declaration is here
      ADC adc = {
          ^
    
    Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
    Message-ID: <20231009100251.56019-8-philmd@linaro.org>
    Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
    ec3ad0fa
    tests/npcm7xx_adc: Clean up global variable shadowing
    Philippe Mathieu-Daudé authored
    
    
    Rename the global 'adc' variable in order to avoid:
    
      tests/qtest/npcm7xx_adc-test.c:98:58: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static uint32_t adc_read_con(QTestState *qts, const ADC *adc)
                                                               ^
      tests/qtest/npcm7xx_adc-test.c:103:55: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_write_con(QTestState *qts, const ADC *adc, uint32_t value)
                                                            ^
      tests/qtest/npcm7xx_adc-test.c:108:59: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static uint32_t adc_read_data(QTestState *qts, const ADC *adc)
                                                                ^
      tests/qtest/npcm7xx_adc-test.c:119:53: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_qom_set(QTestState *qts, const ADC *adc,
                                                          ^
      tests/qtest/npcm7xx_adc-test.c:135:57: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_write_input(QTestState *qts, const ADC *adc,
                                                              ^
      tests/qtest/npcm7xx_adc-test.c:144:56: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_write_vref(QTestState *qts, const ADC *adc, uint32_t value)
                                                             ^
      tests/qtest/npcm7xx_adc-test.c:162:59: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static uint32_t adc_prescaler(QTestState *qts, const ADC *adc)
                                                                ^
      tests/qtest/npcm7xx_adc-test.c:175:64: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      static void adc_wait_conv_finished(QTestState *qts, const ADC *adc,
                                                                     ^
      tests/qtest/npcm7xx_adc-test.c:196:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:207:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:235:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:267:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:293:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:311:16: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
        const ADC *adc = adc_p;
                   ^
      tests/qtest/npcm7xx_adc-test.c:93:5: note: previous declaration is here
      ADC adc = {
          ^
    
    Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
    Message-ID: <20231009100251.56019-8-philmd@linaro.org>
    Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Loading