Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    e9e52efd
    block/io: support int64_t bytes in read/write wrappers · e9e52efd
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are generally moving to int64_t for both offset and bytes parameters
    on all io paths.
    
    Main motivation is realization of 64-bit write_zeroes operation for
    fast zeroing large disk chunks, up to the whole disk.
    
    We chose signed type, to be consistent with off_t (which is signed) and
    with possibility for signed return type (where negative value means
    error).
    
    Now, since bdrv_co_preadv_part() and bdrv_co_pwritev_part() have been
    updated, update all their wrappers.
    
    For all of them type of 'bytes' is widening, so callers are safe. We
    have update request_fn in blkverify.c simultaneously. Still it's just a
    pointer to one of bdrv_co_pwritev() or bdrv_co_preadv(), and type is
    widening for callers of the request_fn anyway.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201211183934.169161-16-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    [eblake: grammar tweak]
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    e9e52efd
    block/io: support int64_t bytes in read/write wrappers
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are generally moving to int64_t for both offset and bytes parameters
    on all io paths.
    
    Main motivation is realization of 64-bit write_zeroes operation for
    fast zeroing large disk chunks, up to the whole disk.
    
    We chose signed type, to be consistent with off_t (which is signed) and
    with possibility for signed return type (where negative value means
    error).
    
    Now, since bdrv_co_preadv_part() and bdrv_co_pwritev_part() have been
    updated, update all their wrappers.
    
    For all of them type of 'bytes' is widening, so callers are safe. We
    have update request_fn in blkverify.c simultaneously. Still it's just a
    pointer to one of bdrv_co_pwritev() or bdrv_co_preadv(), and type is
    widening for callers of the request_fn anyway.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201211183934.169161-16-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    [eblake: grammar tweak]
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Loading