Skip to content
  • Eric Blake's avatar
    15e39ad9
    qemu-img: Add convert --bitmaps option · 15e39ad9
    Eric Blake authored
    Make it easier to copy all the persistent bitmaps of (the top layer
    of) a source image along with its guest-visible contents, by adding a
    boolean flag for use with qemu-img convert.  This is basically
    shorthand, as the same effect could be accomplished with a series of
    'qemu-img bitmap --add' and 'qemu-img bitmap --merge -b source'
    commands, or by their corresponding QMP commands.
    
    Note that this command will fail in the same scenarios where 'qemu-img
    measure' omits a 'bitmaps size:' line, namely, when either the source
    or the destination lacks persistent bitmap support altogether.
    
    See also https://bugzilla.redhat.com/show_bug.cgi?id=1779893
    
    
    
    While touching this, clean up a couple coding issues spotted in the
    same function: an extra blank line, and merging back-to-back 'if
    (!skip_create)' blocks.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20200521192137.1120211-5-eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    15e39ad9
    qemu-img: Add convert --bitmaps option
    Eric Blake authored
    Make it easier to copy all the persistent bitmaps of (the top layer
    of) a source image along with its guest-visible contents, by adding a
    boolean flag for use with qemu-img convert.  This is basically
    shorthand, as the same effect could be accomplished with a series of
    'qemu-img bitmap --add' and 'qemu-img bitmap --merge -b source'
    commands, or by their corresponding QMP commands.
    
    Note that this command will fail in the same scenarios where 'qemu-img
    measure' omits a 'bitmaps size:' line, namely, when either the source
    or the destination lacks persistent bitmap support altogether.
    
    See also https://bugzilla.redhat.com/show_bug.cgi?id=1779893
    
    
    
    While touching this, clean up a couple coding issues spotted in the
    same function: an extra blank line, and merging back-to-back 'if
    (!skip_create)' blocks.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20200521192137.1120211-5-eblake@redhat.com>
    Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Loading