Skip to content
  • Fam Zheng's avatar
    fc0932fd
    block: Reuse bs as backing hd for drive-backup sync=none · fc0932fd
    Fam Zheng authored
    
    
    Opening the backing image for the second time is bad, especially here
    when it is also in use as the active image as the source. The
    drive-backup job itself doesn't read from target->backing for COW,
    instead it gets data from the write notifier, so it's not a big problem.
    However, exporting the target to NBD etc. won't work, because of the
    likely stale metadata cache.
    
    Use BDRV_O_NO_BACKING in this case and manually set up the backing
    BdrvChild.
    
    Cc: qemu-stable@nongnu.org
    Signed-off-by: default avatarFam Zheng <famz@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    fc0932fd
    block: Reuse bs as backing hd for drive-backup sync=none
    Fam Zheng authored
    
    
    Opening the backing image for the second time is bad, especially here
    when it is also in use as the active image as the source. The
    drive-backup job itself doesn't read from target->backing for COW,
    instead it gets data from the write notifier, so it's not a big problem.
    However, exporting the target to NBD etc. won't work, because of the
    likely stale metadata cache.
    
    Use BDRV_O_NO_BACKING in this case and manually set up the backing
    BdrvChild.
    
    Cc: qemu-stable@nongnu.org
    Signed-off-by: default avatarFam Zheng <famz@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading