Skip to content
  • Hanna Reitz's avatar
    228345bf
    block: Support BDRV_REQ_WRITE_UNCHANGED in filters · 228345bf
    Hanna Reitz authored
    
    
    Update the rest of the filter drivers to support
    BDRV_REQ_WRITE_UNCHANGED.  They already forward write request flags to
    their children, so we just have to announce support for it.
    
    This patch does not cover the replication driver because that currently
    does not support flags at all, and because it just grabs the WRITE
    permission for its children when it can, so we should be fine just
    submitting the incoming WRITE_UNCHANGED requests as normal writes.
    
    It also does not cover format drivers for similar reasons.  They all use
    bdrv_format_default_perms() as their .bdrv_child_perm() implementation
    so they just always grab the WRITE permission for their file children
    whenever possible.  In addition, it often would be difficult to
    ascertain whether incoming unchanging writes end up as unchanging writes
    in their files.  So we just leave them as normal potentially changing
    writes.
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarAlberto Garcia <berto@igalia.com>
    Message-id: 20180421132929.21610-7-mreitz@redhat.com
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    228345bf
    block: Support BDRV_REQ_WRITE_UNCHANGED in filters
    Hanna Reitz authored
    
    
    Update the rest of the filter drivers to support
    BDRV_REQ_WRITE_UNCHANGED.  They already forward write request flags to
    their children, so we just have to announce support for it.
    
    This patch does not cover the replication driver because that currently
    does not support flags at all, and because it just grabs the WRITE
    permission for its children when it can, so we should be fine just
    submitting the incoming WRITE_UNCHANGED requests as normal writes.
    
    It also does not cover format drivers for similar reasons.  They all use
    bdrv_format_default_perms() as their .bdrv_child_perm() implementation
    so they just always grab the WRITE permission for their file children
    whenever possible.  In addition, it often would be difficult to
    ascertain whether incoming unchanging writes end up as unchanging writes
    in their files.  So we just leave them as normal potentially changing
    writes.
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarAlberto Garcia <berto@igalia.com>
    Message-id: 20180421132929.21610-7-mreitz@redhat.com
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Loading