Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    d544f5d3
    block: make BlockLimits::max_pwrite_zeroes 64bit · d544f5d3
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are going to support 64 bit write-zeroes requests. Now update the
    limit variable. It's absolutely safe. The variable is set in some
    drivers, and used in bdrv_co_do_pwrite_zeroes().
    
    Update also max_write_zeroes variable in bdrv_co_do_pwrite_zeroes(), so
    that bdrv_co_do_pwrite_zeroes() is now prepared to 64bit requests. The
    remaining logic including num, offset and bytes variables is already
    supporting 64bit requests.
    
    So the only thing that prevents 64 bit requests is limiting
    max_write_zeroes variable to INT_MAX in bdrv_co_do_pwrite_zeroes().
    We'll drop this limitation after updating all block drivers.
    
    Ah, we also have bdrv_check_request32() in bdrv_co_pwritev_part(). It
    will be modified to do bdrv_check_request() for write-zeroes path.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20210903102807.27127-7-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    d544f5d3
    block: make BlockLimits::max_pwrite_zeroes 64bit
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are going to support 64 bit write-zeroes requests. Now update the
    limit variable. It's absolutely safe. The variable is set in some
    drivers, and used in bdrv_co_do_pwrite_zeroes().
    
    Update also max_write_zeroes variable in bdrv_co_do_pwrite_zeroes(), so
    that bdrv_co_do_pwrite_zeroes() is now prepared to 64bit requests. The
    remaining logic including num, offset and bytes variables is already
    supporting 64bit requests.
    
    So the only thing that prevents 64 bit requests is limiting
    max_write_zeroes variable to INT_MAX in bdrv_co_do_pwrite_zeroes().
    We'll drop this limitation after updating all block drivers.
    
    Ah, we also have bdrv_check_request32() in bdrv_co_pwritev_part(). It
    will be modified to do bdrv_check_request() for write-zeroes path.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20210903102807.27127-7-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Loading