Skip to content
  • Greg Kurz's avatar
    72f0d0bf
    9pfs: local: lremovexattr: don't follow symlinks · 72f0d0bf
    Greg Kurz authored
    
    
    The local_lremovexattr() callback is vulnerable to symlink attacks because
    it calls lremovexattr() which follows symbolic links in all path elements
    but the rightmost one.
    
    This patch introduces a helper to emulate the non-existing fremovexattrat()
    function: it is implemented with /proc/self/fd which provides a trusted
    path that can be safely passed to lremovexattr().
    
    local_lremovexattr() is converted to use this helper and opendir_nofollow().
    
    This partly fixes CVE-2016-9602.
    
    Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    72f0d0bf
    9pfs: local: lremovexattr: don't follow symlinks
    Greg Kurz authored
    
    
    The local_lremovexattr() callback is vulnerable to symlink attacks because
    it calls lremovexattr() which follows symbolic links in all path elements
    but the rightmost one.
    
    This patch introduces a helper to emulate the non-existing fremovexattrat()
    function: it is implemented with /proc/self/fd which provides a trusted
    path that can be safely passed to lremovexattr().
    
    local_lremovexattr() is converted to use this helper and opendir_nofollow().
    
    This partly fixes CVE-2016-9602.
    
    Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Loading