Skip to content
  • David Hildenbrand's avatar
    cdfa56c5
    softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory · cdfa56c5
    David Hildenbrand authored
    
    
    We can create shared anonymous memory via
        "-object memory-backend-ram,share=on,..."
    which is, for example, required by PVRDMA for mremap() to work.
    
    Shared anonymous memory is weird, though. Instead of MADV_DONTNEED, we
    have to use MADV_REMOVE: MADV_DONTNEED will only remove / zap all
    relevant page table entries of the current process, the backend storage
    will not get removed, resulting in no reduced memory consumption and
    a repopulation of previous content on next access.
    
    Shared anonymous memory is internally really just shmem, but without a
    fd exposed. As we cannot use fallocate() without the fd to discard the
    backing storage, MADV_REMOVE gets the same job done without a fd as
    documented in "man 2 madvise". Removing backing storage implicitly
    invalidates all page table entries with relevant mappings - an additional
    MADV_DONTNEED is not required.
    
    Fixes: 06329cce ("mem: add share parameter to memory-backend-ram")
    Reviewed-by: default avatarPeter Xu <peterx@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Message-Id: <20210406080126.24010-3-david@redhat.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    cdfa56c5
    softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory
    David Hildenbrand authored
    
    
    We can create shared anonymous memory via
        "-object memory-backend-ram,share=on,..."
    which is, for example, required by PVRDMA for mremap() to work.
    
    Shared anonymous memory is weird, though. Instead of MADV_DONTNEED, we
    have to use MADV_REMOVE: MADV_DONTNEED will only remove / zap all
    relevant page table entries of the current process, the backend storage
    will not get removed, resulting in no reduced memory consumption and
    a repopulation of previous content on next access.
    
    Shared anonymous memory is internally really just shmem, but without a
    fd exposed. As we cannot use fallocate() without the fd to discard the
    backing storage, MADV_REMOVE gets the same job done without a fd as
    documented in "man 2 madvise". Removing backing storage implicitly
    invalidates all page table entries with relevant mappings - an additional
    MADV_DONTNEED is not required.
    
    Fixes: 06329cce ("mem: add share parameter to memory-backend-ram")
    Reviewed-by: default avatarPeter Xu <peterx@redhat.com>
    Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
    Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Message-Id: <20210406080126.24010-3-david@redhat.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Loading