Skip to content
  • Kevin Wolf's avatar
    c83f9fba
    block/qapi: Use blk_enable_write_cache() · c83f9fba
    Kevin Wolf authored
    
    
    Now that WCE is handled on the BlockBackend level, the flag is
    meaningless for BDSes. As the schema requires us to fill the field,
    we return an enabled write cache for them.
    
    Note that this means that querying the BlockBackend name may return
    writethrough as the cache information, whereas querying the node-name of
    the root of that same BlockBackend will return writeback.
    
    This may appear odd at first, but it actually makes sense because it
    correctly repesents the layer that implements the WCE handling. This
    becomes more apparent when you consider nodes that are the root node of
    multiple BlockBackends, where each BB can have its own WCE setting.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    c83f9fba
    block/qapi: Use blk_enable_write_cache()
    Kevin Wolf authored
    
    
    Now that WCE is handled on the BlockBackend level, the flag is
    meaningless for BDSes. As the schema requires us to fill the field,
    we return an enabled write cache for them.
    
    Note that this means that querying the BlockBackend name may return
    writethrough as the cache information, whereas querying the node-name of
    the root of that same BlockBackend will return writeback.
    
    This may appear odd at first, but it actually makes sense because it
    correctly repesents the layer that implements the WCE handling. This
    becomes more apparent when you consider nodes that are the root node of
    multiple BlockBackends, where each BB can have its own WCE setting.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Loading