Skip to content
  • Markus Armbruster's avatar
    e178113f
    hw: Replace anti-social QOM type names · e178113f
    Markus Armbruster authored
    
    
    Several QOM type names contain ',':
    
        ARM,bitband-memory
        etraxfs,pic
        etraxfs,serial
        etraxfs,timer
        fsl,imx25
        fsl,imx31
        fsl,imx6
        fsl,imx6ul
        fsl,imx7
        grlib,ahbpnp
        grlib,apbpnp
        grlib,apbuart
        grlib,gptimer
        grlib,irqmp
        qemu,register
        SUNW,bpp
        SUNW,CS4231
        SUNW,DBRI
        SUNW,DBRI.prom
        SUNW,fdtwo
        SUNW,sx
        SUNW,tcx
        xilinx,zynq_slcr
        xlnx,zynqmp
        xlnx,zynqmp-pmu-soc
        xlnx,zynq-xadc
    
    These are all device types.  They can't be plugged with -device /
    device_add, except for xlnx,zynqmp-pmu-soc, and I doubt that one
    actually works.
    
    They *can* be used with -device / device_add to request help.
    Usability is poor, though: you have to double the comma, like this:
    
        $ qemu-system-x86_64 -device SUNW,,fdtwo,help
    
    Trap for the unwary.  The fact that this was broken in
    device-introspect-test for more than six years until commit e27bd498
    fixed it demonstrates that "the unwary" includes seasoned developers.
    
    One QOM type name contains ' ': "ICH9 SMB".  Because having to
    remember just one way to quote would be too easy.
    
    Rename the "SUNW,FOO types to "sun-FOO".  Summarily replace ',' and '
    ' by '-' in the other type names.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <20210304140229.575481-2-armbru@redhat.com>
    Reviewed-by: default avatarMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
    Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    e178113f
    hw: Replace anti-social QOM type names
    Markus Armbruster authored
    
    
    Several QOM type names contain ',':
    
        ARM,bitband-memory
        etraxfs,pic
        etraxfs,serial
        etraxfs,timer
        fsl,imx25
        fsl,imx31
        fsl,imx6
        fsl,imx6ul
        fsl,imx7
        grlib,ahbpnp
        grlib,apbpnp
        grlib,apbuart
        grlib,gptimer
        grlib,irqmp
        qemu,register
        SUNW,bpp
        SUNW,CS4231
        SUNW,DBRI
        SUNW,DBRI.prom
        SUNW,fdtwo
        SUNW,sx
        SUNW,tcx
        xilinx,zynq_slcr
        xlnx,zynqmp
        xlnx,zynqmp-pmu-soc
        xlnx,zynq-xadc
    
    These are all device types.  They can't be plugged with -device /
    device_add, except for xlnx,zynqmp-pmu-soc, and I doubt that one
    actually works.
    
    They *can* be used with -device / device_add to request help.
    Usability is poor, though: you have to double the comma, like this:
    
        $ qemu-system-x86_64 -device SUNW,,fdtwo,help
    
    Trap for the unwary.  The fact that this was broken in
    device-introspect-test for more than six years until commit e27bd498
    fixed it demonstrates that "the unwary" includes seasoned developers.
    
    One QOM type name contains ' ': "ICH9 SMB".  Because having to
    remember just one way to quote would be too easy.
    
    Rename the "SUNW,FOO types to "sun-FOO".  Summarily replace ',' and '
    ' by '-' in the other type names.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <20210304140229.575481-2-armbru@redhat.com>
    Reviewed-by: default avatarMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
    Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Loading