Skip to content
  • Greg Kurz's avatar
    be4d026f
    vfio-ccw: fix memory leaks in vfio_ccw_realize() · be4d026f
    Greg Kurz authored
    
    
    If the subchannel is already attached or if vfio_get_device() fails, the
    code jumps to the 'out_device_err' label and doesn't free the string it
    has just allocated.
    
    The code should be reworked so that vcdev->vdev.name only gets set when
    the device has been attached, and freed when it is about to be detached.
    This could be achieved  with the addition of a vfio_ccw_get_device()
    function that would be the counterpart of vfio_put_device(). But this is
    a more elaborate cleanup that should be done in a follow-up. For now,
    let's just add calls to g_free() on the buggy error paths.
    
    Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
    Message-Id: <152311222681.203086.8874800175539040298.stgit@bahia>
    Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
    be4d026f
    vfio-ccw: fix memory leaks in vfio_ccw_realize()
    Greg Kurz authored
    
    
    If the subchannel is already attached or if vfio_get_device() fails, the
    code jumps to the 'out_device_err' label and doesn't free the string it
    has just allocated.
    
    The code should be reworked so that vcdev->vdev.name only gets set when
    the device has been attached, and freed when it is about to be detached.
    This could be achieved  with the addition of a vfio_ccw_get_device()
    function that would be the counterpart of vfio_put_device(). But this is
    a more elaborate cleanup that should be done in a follow-up. For now,
    let's just add calls to g_free() on the buggy error paths.
    
    Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
    Message-Id: <152311222681.203086.8874800175539040298.stgit@bahia>
    Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
Loading