Skip to content
  • Peter Maydell's avatar
    17e31340
    Remove unnecessary minimum_version_id_old fields · 17e31340
    Peter Maydell authored
    
    
    The migration code will not look at a VMStateDescription's
    minimum_version_id_old field unless that VMSD has set the
    load_state_old field to something non-NULL.  (The purpose of
    minimum_version_id_old is to specify what migration version is needed
    for the code in the function pointed to by load_state_old to be able
    to handle it on incoming migration.)
    
    We have exactly one VMSD which still has a load_state_old,
    in the PPC CPU; every other VMSD which sets minimum_version_id_old
    is doing so unnecessarily. Delete all the unnecessary ones.
    
    Commit created with:
      sed -i '/\.minimum_version_id_old/d' $(git grep -l '\.minimum_version_id_old')
    with the one legitimate use then hand-edited back in.
    
    Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
    Reviewed-by: default avatarJuan Quintela <quintela@redhat.com>
    
    Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
    
    ---
    
    It missed vmstate_ppc_cpu.
    17e31340
    Remove unnecessary minimum_version_id_old fields
    Peter Maydell authored
    
    
    The migration code will not look at a VMStateDescription's
    minimum_version_id_old field unless that VMSD has set the
    load_state_old field to something non-NULL.  (The purpose of
    minimum_version_id_old is to specify what migration version is needed
    for the code in the function pointed to by load_state_old to be able
    to handle it on incoming migration.)
    
    We have exactly one VMSD which still has a load_state_old,
    in the PPC CPU; every other VMSD which sets minimum_version_id_old
    is doing so unnecessarily. Delete all the unnecessary ones.
    
    Commit created with:
      sed -i '/\.minimum_version_id_old/d' $(git grep -l '\.minimum_version_id_old')
    with the one legitimate use then hand-edited back in.
    
    Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
    Reviewed-by: default avatarJuan Quintela <quintela@redhat.com>
    
    Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
    
    ---
    
    It missed vmstate_ppc_cpu.
Loading