-
Kevin Wolf authored
The immediately visible effect of this patch is that it fixes committing a temporary snapshot to its backing file. Previously, it would fail with a "permission denied" error because bdrv_inherited_flags() forced the backing file to be read-only, ignoring the r/w reopen of bdrv_commit(). The bigger problem this revealed is that the original open flags must actually only be applied to the temporary snapshot, and the original image file must be treated as a backing file of the temporary snapshot and get the right flags for that. Reported-by:
Jan Kiszka <jan.kiszka@web.de>
Signed-off-by:
Kevin Wolf <kwolf@redhat.com>
Reviewed-by:
Max Reitz <mreitz@redhat.com>
Signed-off-by:
Stefan Hajnoczi <stefanha@redhat.com>Kevin Wolf authoredThe immediately visible effect of this patch is that it fixes committing a temporary snapshot to its backing file. Previously, it would fail with a "permission denied" error because bdrv_inherited_flags() forced the backing file to be read-only, ignoring the r/w reopen of bdrv_commit(). The bigger problem this revealed is that the original open flags must actually only be applied to the temporary snapshot, and the original image file must be treated as a backing file of the temporary snapshot and get the right flags for that. Reported-by:
Jan Kiszka <jan.kiszka@web.de>
Signed-off-by:
Kevin Wolf <kwolf@redhat.com>
Reviewed-by:
Max Reitz <mreitz@redhat.com>
Signed-off-by:
Stefan Hajnoczi <stefanha@redhat.com>
Loading