Skip to content
  • Jia Liu's avatar
    b6d9766d
    hw/openrisc: Avoid using uninitialised variable 'entry' · b6d9766d
    Jia Liu authored
    
    
    clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized:
    
    hw/openrisc/openrisc_sim.c:69:9: error: variable 'entry' is used uninitialized
    whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized]
    
        if (kernel_filename && !qtest_enabled()) {
            ^~~~~~~~~~~~~~~
    hw/openrisc/openrisc_sim.c:91:19: note: uninitialized use occurs here
        cpu->env.pc = entry;
                      ^~~~~
    
    Fix this by not attempting to change the CPU's starting PC unless
    we actually loaded a kernel.
    
    Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
    Reviewed-by: default avatarJia Liu <proljc@gmail.com>
    b6d9766d
    hw/openrisc: Avoid using uninitialised variable 'entry'
    Jia Liu authored
    
    
    clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized:
    
    hw/openrisc/openrisc_sim.c:69:9: error: variable 'entry' is used uninitialized
    whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized]
    
        if (kernel_filename && !qtest_enabled()) {
            ^~~~~~~~~~~~~~~
    hw/openrisc/openrisc_sim.c:91:19: note: uninitialized use occurs here
        cpu->env.pc = entry;
                      ^~~~~
    
    Fix this by not attempting to change the CPU's starting PC unless
    we actually loaded a kernel.
    
    Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
    Reviewed-by: default avatarJia Liu <proljc@gmail.com>
Loading