Skip to content
  • Eric Blake's avatar
    f61ffad5
    qemu-coroutine-sleep: Silence Coverity warning · f61ffad5
    Eric Blake authored
    
    
    Coverity warns that we store the address of a stack variable through a
    pointer passed in by the caller, which would let the caller trivially
    trigger use-after-free if that stored value is still present when we
    finish execution.  However, the way coroutines work is that after our
    call to qemu_coroutine_yield(), control is temporarily continued in
    the caller prior to our function concluding, and in order to resume
    our coroutine, the caller must poll until the variable has been set to
    NULL.  Thus, we can add an assert that we do not leak stack storage to
    the caller on function exit.
    
    Fixes: Coverity CID 1406474
    CC: Peter Maydell <peter.maydell@linaro.org>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20191111203524.21912-1-eblake@redhat.com>
    Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
    f61ffad5
    qemu-coroutine-sleep: Silence Coverity warning
    Eric Blake authored
    
    
    Coverity warns that we store the address of a stack variable through a
    pointer passed in by the caller, which would let the caller trivially
    trigger use-after-free if that stored value is still present when we
    finish execution.  However, the way coroutines work is that after our
    call to qemu_coroutine_yield(), control is temporarily continued in
    the caller prior to our function concluding, and in order to resume
    our coroutine, the caller must poll until the variable has been set to
    NULL.  Thus, we can add an assert that we do not leak stack storage to
    the caller on function exit.
    
    Fixes: Coverity CID 1406474
    CC: Peter Maydell <peter.maydell@linaro.org>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20191111203524.21912-1-eblake@redhat.com>
    Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Loading