Skip to content
  • John Snow's avatar
    ac897611
    qapi/error: assert QAPISourceInfo is not None · ac897611
    John Snow authored
    
    
    Built-in stuff is not parsed from a source file, and therefore have no
    QAPISourceInfo. If such None info was used for reporting an error,
    built-in stuff would be broken. Programming error. Instead of reporting
    a confusing error with bogus source location then, we better crash.
    
    We currently crash only if self.col was set. Assert that self.info is
    not None in order to crash reliably.
    
    We can not yet change the type of the initializer to prove this cannot
    happen at static analysis time before the remainder of the code is fully
    typed.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Message-Id: <20210421192233.3542904-5-jsnow@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    ac897611
    qapi/error: assert QAPISourceInfo is not None
    John Snow authored
    
    
    Built-in stuff is not parsed from a source file, and therefore have no
    QAPISourceInfo. If such None info was used for reporting an error,
    built-in stuff would be broken. Programming error. Instead of reporting
    a confusing error with bogus source location then, we better crash.
    
    We currently crash only if self.col was set. Assert that self.info is
    not None in order to crash reliably.
    
    We can not yet change the type of the initializer to prove this cannot
    happen at static analysis time before the remainder of the code is fully
    typed.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Message-Id: <20210421192233.3542904-5-jsnow@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Loading