Skip to content
  • Kevin Wolf's avatar
    a527e312
    vhost-user-blk: Implement reconnection during realize · a527e312
    Kevin Wolf authored
    
    
    Commit dabefdd6 removed code that was supposed to try reconnecting
    during .realize(), but actually just crashed and had several design
    problems.
    
    This adds the feature back without the crash in simple cases while also
    fixing some design problems: Reconnection is now only tried if there was
    a problem with the connection and not an error related to the content
    (which would fail again the same way in the next attempt). Reconnection
    is limited to three attempts (four with the initial attempt) so that we
    won't end up in an infinite loop if a problem is permanent. If the
    backend restarts three times in the very short time window of device
    initialisation, we have bigger problems and erroring out is the right
    course of action.
    
    In the case that a connection error occurs and we reconnect, the error
    message is printed using error_report_err(), but otherwise ignored.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Message-Id: <20210609154658.350308-8-kwolf@redhat.com>
    Reviewed-by: default avatarRaphael Norwitz <raphael.norwitz@nutanix.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    a527e312
    vhost-user-blk: Implement reconnection during realize
    Kevin Wolf authored
    
    
    Commit dabefdd6 removed code that was supposed to try reconnecting
    during .realize(), but actually just crashed and had several design
    problems.
    
    This adds the feature back without the crash in simple cases while also
    fixing some design problems: Reconnection is now only tried if there was
    a problem with the connection and not an error related to the content
    (which would fail again the same way in the next attempt). Reconnection
    is limited to three attempts (four with the initial attempt) so that we
    won't end up in an infinite loop if a problem is permanent. If the
    backend restarts three times in the very short time window of device
    initialisation, we have bigger problems and erroring out is the right
    course of action.
    
    In the case that a connection error occurs and we reconnect, the error
    message is printed using error_report_err(), but otherwise ignored.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Message-Id: <20210609154658.350308-8-kwolf@redhat.com>
    Reviewed-by: default avatarRaphael Norwitz <raphael.norwitz@nutanix.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading