Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    a5215b8f
    block/io: use int64_t bytes in copy_range · a5215b8f
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are generally moving to int64_t for both offset and bytes parameters
    on all io paths.
    
    Main motivation is realization of 64-bit write_zeroes operation for
    fast zeroing large disk chunks, up to the whole disk.
    
    We chose signed type, to be consistent with off_t (which is signed) and
    with possibility for signed return type (where negative value means
    error).
    
    So, convert now copy_range parameters which are already 64bit to signed
    type.
    
    It's safe as we don't work with requests overflowing BDRV_MAX_LENGTH
    (which is less than INT64_MAX), and do check the requests in
    bdrv_co_copy_range_internal() (by bdrv_check_request32(), which calls
    bdrv_check_request()).
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201211183934.169161-17-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    a5215b8f
    block/io: use int64_t bytes in copy_range
    Vladimir Sementsov-Ogievskiy authored
    
    
    We are generally moving to int64_t for both offset and bytes parameters
    on all io paths.
    
    Main motivation is realization of 64-bit write_zeroes operation for
    fast zeroing large disk chunks, up to the whole disk.
    
    We chose signed type, to be consistent with off_t (which is signed) and
    with possibility for signed return type (where negative value means
    error).
    
    So, convert now copy_range parameters which are already 64bit to signed
    type.
    
    It's safe as we don't work with requests overflowing BDRV_MAX_LENGTH
    (which is less than INT64_MAX), and do check the requests in
    bdrv_co_copy_range_internal() (by bdrv_check_request32(), which calls
    bdrv_check_request()).
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20201211183934.169161-17-vsementsov@virtuozzo.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Loading