Skip to content
  • Kevin Wolf's avatar
    b2c2832c
    block: Add Error parameter to bdrv_append() · b2c2832c
    Kevin Wolf authored
    
    
    Aborting on error in bdrv_append() isn't correct. This patch fixes it
    and lets the callers handle failures.
    
    Test case 085 needs a reference output update. This is caused by the
    reversed order of bdrv_set_backing_hd() and change_parent_backing_link()
    in bdrv_append(): When the backing file of the new node is set, the
    parent nodes are still pointing to the old top, so the backing blocker
    is now initialised with the node name rather than the BlockBackend name.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Acked-by: default avatarFam Zheng <famz@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    b2c2832c
    block: Add Error parameter to bdrv_append()
    Kevin Wolf authored
    
    
    Aborting on error in bdrv_append() isn't correct. This patch fixes it
    and lets the callers handle failures.
    
    Test case 085 needs a reference output update. This is caused by the
    reversed order of bdrv_set_backing_hd() and change_parent_backing_link()
    in bdrv_append(): When the backing file of the new node is set, the
    parent nodes are still pointing to the old top, so the backing blocker
    is now initialised with the node name rather than the BlockBackend name.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Acked-by: default avatarFam Zheng <famz@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Loading