Skip to content
  • Stefan Hajnoczi's avatar
    84d61e5f
    virtio: use defer_call() in virtio_irqfd_notify() · 84d61e5f
    Stefan Hajnoczi authored
    virtio-blk and virtio-scsi invoke virtio_irqfd_notify() to send Used
    Buffer Notifications from an IOThread. This involves an eventfd
    write(2) syscall. Calling this repeatedly when completing multiple I/O
    requests in a row is wasteful.
    
    Use the defer_call() API to batch together virtio_irqfd_notify() calls
    made during thread pool (aio=threads), Linux AIO (aio=native), and
    io_uring (aio=io_uring) completion processing.
    
    Behavior is unchanged for emulated devices that do not use
    defer_call_begin()/defer_call_end() since defer_call() immediately
    invokes the callback when called outside a
    defer_call_begin()/defer_call_end() region.
    
    fio rw=randread bs=4k iodepth=64 numjobs=8 IOPS increases by ~9% with a
    single IOThread and 8 vCPUs. iodepth=1 decreases by ~1% but this could
    be noise. Detailed performance data and configuration specifics are
    available here:
    https://gitlab.com/stefanha/virt-playbooks/-/tree/blk_io_plug-irqfd
    
    
    
    This duplicates the BH that virtio-blk uses for batching. The next
    commit will remove it.
    
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Message-ID: <20230913200045.1024233-4-stefanha@redhat.com>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    84d61e5f
    virtio: use defer_call() in virtio_irqfd_notify()
    Stefan Hajnoczi authored
    virtio-blk and virtio-scsi invoke virtio_irqfd_notify() to send Used
    Buffer Notifications from an IOThread. This involves an eventfd
    write(2) syscall. Calling this repeatedly when completing multiple I/O
    requests in a row is wasteful.
    
    Use the defer_call() API to batch together virtio_irqfd_notify() calls
    made during thread pool (aio=threads), Linux AIO (aio=native), and
    io_uring (aio=io_uring) completion processing.
    
    Behavior is unchanged for emulated devices that do not use
    defer_call_begin()/defer_call_end() since defer_call() immediately
    invokes the callback when called outside a
    defer_call_begin()/defer_call_end() region.
    
    fio rw=randread bs=4k iodepth=64 numjobs=8 IOPS increases by ~9% with a
    single IOThread and 8 vCPUs. iodepth=1 decreases by ~1% but this could
    be noise. Detailed performance data and configuration specifics are
    available here:
    https://gitlab.com/stefanha/virt-playbooks/-/tree/blk_io_plug-irqfd
    
    
    
    This duplicates the BH that virtio-blk uses for batching. The next
    commit will remove it.
    
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Message-ID: <20230913200045.1024233-4-stefanha@redhat.com>
    Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading