Skip to content
  • Peter Krempa's avatar
    6bff597b
    block: don't add 'driver' to options when referring to backing via node name · 6bff597b
    Peter Krempa authored
    
    
    When referring to a backing file of an image via node name
    bdrv_open_backing_file would add the 'driver' option to the option list
    filling it with the backing format driver. This breaks construction of
    the backing chain via -blockdev, as bdrv_open_inherit reports an error
    if both 'reference' and 'options' are provided.
    
    $ qemu-img create -f raw /tmp/backing.raw 64M
    $ qemu-img create -f qcow2 -F raw -b /tmp/backing.raw /tmp/test.qcow2
    $ qemu-system-x86_64 \
      -blockdev driver=file,filename=/tmp/backing.raw,node-name=backing \
      -blockdev driver=qcow2,file.driver=file,file.filename=/tmp/test.qcow2,node-name=root,backing=backing
    qemu-system-x86_64: -blockdev driver=qcow2,file.driver=file,file.filename=/tmp/test.qcow2,node-name=root,backing=backing: Could not open backing file: Cannot reference an existing block device with additional options or a new filename
    
    Signed-off-by: default avatarPeter Krempa <pkrempa@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    6bff597b
    block: don't add 'driver' to options when referring to backing via node name
    Peter Krempa authored
    
    
    When referring to a backing file of an image via node name
    bdrv_open_backing_file would add the 'driver' option to the option list
    filling it with the backing format driver. This breaks construction of
    the backing chain via -blockdev, as bdrv_open_inherit reports an error
    if both 'reference' and 'options' are provided.
    
    $ qemu-img create -f raw /tmp/backing.raw 64M
    $ qemu-img create -f qcow2 -F raw -b /tmp/backing.raw /tmp/test.qcow2
    $ qemu-system-x86_64 \
      -blockdev driver=file,filename=/tmp/backing.raw,node-name=backing \
      -blockdev driver=qcow2,file.driver=file,file.filename=/tmp/test.qcow2,node-name=root,backing=backing
    qemu-system-x86_64: -blockdev driver=qcow2,file.driver=file,file.filename=/tmp/test.qcow2,node-name=root,backing=backing: Could not open backing file: Cannot reference an existing block device with additional options or a new filename
    
    Signed-off-by: default avatarPeter Krempa <pkrempa@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Loading