Skip to content
  • Peter Xu's avatar
    5b3ac23f
    iothread: delay the context release to finalize · 5b3ac23f
    Peter Xu authored
    
    
    When gcontext is used with iothread, the context will be destroyed
    during iothread_stop().  That's not good since sometimes we would like
    to keep the resources until iothread is destroyed, but we may want to
    stop the thread before that point.
    
    Delay the destruction of gcontext to iothread finalize.  Then we can do:
    
      iothread_stop(thread);
      some_cleanup_on_resources();
      iothread_destroy(thread);
    
    We may need this patch if we want to run chardev IOs in iothreads and
    hopefully clean them up correctly.  For more specific information,
    please see 2b316774 ("qemu-char: do not operate on sources from
    finalize callbacks").
    
    Reviewed-by: default avatarFam Zheng <famz@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: default avatarPeter Xu <peterx@redhat.com>
    Message-id: 20170928025958.1420-5-peterx@redhat.com
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    5b3ac23f
    iothread: delay the context release to finalize
    Peter Xu authored
    
    
    When gcontext is used with iothread, the context will be destroyed
    during iothread_stop().  That's not good since sometimes we would like
    to keep the resources until iothread is destroyed, but we may want to
    stop the thread before that point.
    
    Delay the destruction of gcontext to iothread finalize.  Then we can do:
    
      iothread_stop(thread);
      some_cleanup_on_resources();
      iothread_destroy(thread);
    
    We may need this patch if we want to run chardev IOs in iothreads and
    hopefully clean them up correctly.  For more specific information,
    please see 2b316774 ("qemu-char: do not operate on sources from
    finalize callbacks").
    
    Reviewed-by: default avatarFam Zheng <famz@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: default avatarPeter Xu <peterx@redhat.com>
    Message-id: 20170928025958.1420-5-peterx@redhat.com
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Loading