Skip to content
  • Markus Armbruster's avatar
    ce189ab2
    qdev: Convert bus-less devices to qdev_realize() with Coccinelle · ce189ab2
    Markus Armbruster authored
    
    
    All remaining conversions to qdev_realize() are for bus-less devices.
    Coccinelle script:
    
        // only correct for bus-less @dev!
    
        @@
        expression errp;
        expression dev;
        @@
        -    qdev_init_nofail(dev);
        +    qdev_realize(dev, NULL, &error_fatal);
    
        @ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
        expression errp;
        expression dev;
        symbol true;
        @@
        -    object_property_set_bool(OBJECT(dev), true, "realized", errp);
        +    qdev_realize(DEVICE(dev), NULL, errp);
    
        @ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
        expression errp;
        expression dev;
        symbol true;
        @@
        -    object_property_set_bool(dev, true, "realized", errp);
        +    qdev_realize(DEVICE(dev), NULL, errp);
    
    Note that Coccinelle chokes on ARMSSE typedef vs. macro in
    hw/arm/armsse.c.  Worked around by temporarily renaming the macro for
    the spatch run.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Acked-by: default avatarAlistair Francis <alistair.francis@wdc.com>
    Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Message-Id: <20200610053247.1583243-57-armbru@redhat.com>
    ce189ab2
    qdev: Convert bus-less devices to qdev_realize() with Coccinelle
    Markus Armbruster authored
    
    
    All remaining conversions to qdev_realize() are for bus-less devices.
    Coccinelle script:
    
        // only correct for bus-less @dev!
    
        @@
        expression errp;
        expression dev;
        @@
        -    qdev_init_nofail(dev);
        +    qdev_realize(dev, NULL, &error_fatal);
    
        @ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
        expression errp;
        expression dev;
        symbol true;
        @@
        -    object_property_set_bool(OBJECT(dev), true, "realized", errp);
        +    qdev_realize(DEVICE(dev), NULL, errp);
    
        @ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
        expression errp;
        expression dev;
        symbol true;
        @@
        -    object_property_set_bool(dev, true, "realized", errp);
        +    qdev_realize(DEVICE(dev), NULL, errp);
    
    Note that Coccinelle chokes on ARMSSE typedef vs. macro in
    hw/arm/armsse.c.  Worked around by temporarily renaming the macro for
    the spatch run.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Acked-by: default avatarAlistair Francis <alistair.francis@wdc.com>
    Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Message-Id: <20200610053247.1583243-57-armbru@redhat.com>
Loading