Skip to content
  • Markus Armbruster's avatar
    934df912
    qdev: Make qdev_prop_set_drive() match the other helpers · 934df912
    Markus Armbruster authored
    
    
    qdev_prop_set_drive() can fail.  None of the other qdev_prop_set_FOO()
    can; they abort on error.
    
    To clean up this inconsistency, rename qdev_prop_set_drive() to
    qdev_prop_set_drive_err(), and create a qdev_prop_set_drive() that
    aborts on error.
    
    Coccinelle script to update callers:
    
        @ depends on !(file in "hw/core/qdev-properties-system.c")@
        expression dev, name, value;
        symbol error_abort;
        @@
        -    qdev_prop_set_drive(dev, name, value, &error_abort);
        +    qdev_prop_set_drive(dev, name, value);
    
        @@
        expression dev, name, value, errp;
        @@
        -    qdev_prop_set_drive(dev, name, value, errp);
        +    qdev_prop_set_drive_err(dev, name, value, errp);
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
    Message-Id: <20200622094227.1271650-14-armbru@redhat.com>
    934df912
    qdev: Make qdev_prop_set_drive() match the other helpers
    Markus Armbruster authored
    
    
    qdev_prop_set_drive() can fail.  None of the other qdev_prop_set_FOO()
    can; they abort on error.
    
    To clean up this inconsistency, rename qdev_prop_set_drive() to
    qdev_prop_set_drive_err(), and create a qdev_prop_set_drive() that
    aborts on error.
    
    Coccinelle script to update callers:
    
        @ depends on !(file in "hw/core/qdev-properties-system.c")@
        expression dev, name, value;
        symbol error_abort;
        @@
        -    qdev_prop_set_drive(dev, name, value, &error_abort);
        +    qdev_prop_set_drive(dev, name, value);
    
        @@
        expression dev, name, value, errp;
        @@
        -    qdev_prop_set_drive(dev, name, value, errp);
        +    qdev_prop_set_drive_err(dev, name, value, errp);
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
    Message-Id: <20200622094227.1271650-14-armbru@redhat.com>
Loading