Skip to content
  • Markus Armbruster's avatar
    78288671
    error: Use error_report_err() instead of ad hoc prints · 78288671
    Markus Armbruster authored
    
    
    Unlike ad hoc prints, error_report_err() uses the error whole instead
    of just its message obtained with error_get_pretty().  This avoids
    suppressing its hint (see commit 50b7b000).  Example:
    
        $ bld/ivshmem-server -l 42@
        Parameter 'shm_size' expects a size
        You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
    
    The last line is new with this patch.
    
    While there, drop a "cannot parse shm size: " message prefix; it's
    redundant, because the error message proper is always of the form
    "Parameter 'shm_size' expects ...".
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <1450452927-8346-5-git-send-email-armbru@redhat.com>
    78288671
    error: Use error_report_err() instead of ad hoc prints
    Markus Armbruster authored
    
    
    Unlike ad hoc prints, error_report_err() uses the error whole instead
    of just its message obtained with error_get_pretty().  This avoids
    suppressing its hint (see commit 50b7b000).  Example:
    
        $ bld/ivshmem-server -l 42@
        Parameter 'shm_size' expects a size
        You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
    
    The last line is new with this patch.
    
    While there, drop a "cannot parse shm size: " message prefix; it's
    redundant, because the error message proper is always of the form
    "Parameter 'shm_size' expects ...".
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <1450452927-8346-5-git-send-email-armbru@redhat.com>
Loading