Skip to content
  • Hanna Reitz's avatar
    998b3a1e
    block: Purify .bdrv_refresh_filename() · 998b3a1e
    Hanna Reitz authored
    
    
    Currently, BlockDriver.bdrv_refresh_filename() is supposed to both
    refresh the filename (BDS.exact_filename) and set BDS.full_open_options.
    Now that we have generic code in the central bdrv_refresh_filename() for
    creating BDS.full_open_options, we can drop the latter part from all
    BlockDriver.bdrv_refresh_filename() implementations.
    
    This also means that we can drop all of the existing default code for
    this from the global bdrv_refresh_filename() itself.
    
    Furthermore, we now have to call BlockDriver.bdrv_refresh_filename()
    after having set BDS.full_open_options, because the block driver's
    implementation should now be allowed to depend on BDS.full_open_options
    being set correctly.
    
    Finally, with this patch we can drop the @options parameter from
    BlockDriver.bdrv_refresh_filename(); also, add a comment on this
    function's purpose in block/block_int.h while touching its interface.
    
    This completely obsoletes blklogwrite's implementation of
    .bdrv_refresh_filename().
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 20190201192935.18394-25-mreitz@redhat.com
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    998b3a1e
    block: Purify .bdrv_refresh_filename()
    Hanna Reitz authored
    
    
    Currently, BlockDriver.bdrv_refresh_filename() is supposed to both
    refresh the filename (BDS.exact_filename) and set BDS.full_open_options.
    Now that we have generic code in the central bdrv_refresh_filename() for
    creating BDS.full_open_options, we can drop the latter part from all
    BlockDriver.bdrv_refresh_filename() implementations.
    
    This also means that we can drop all of the existing default code for
    this from the global bdrv_refresh_filename() itself.
    
    Furthermore, we now have to call BlockDriver.bdrv_refresh_filename()
    after having set BDS.full_open_options, because the block driver's
    implementation should now be allowed to depend on BDS.full_open_options
    being set correctly.
    
    Finally, with this patch we can drop the @options parameter from
    BlockDriver.bdrv_refresh_filename(); also, add a comment on this
    function's purpose in block/block_int.h while touching its interface.
    
    This completely obsoletes blklogwrite's implementation of
    .bdrv_refresh_filename().
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 20190201192935.18394-25-mreitz@redhat.com
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Loading